Chris Lamb:
> tags 886479 + patch
> thanks
>
> Hi,
>
>> lintian: Please detect packages that currently needs R!=no
>
> Draft patch attached:
>
> commit 5a881408f5f5dc8a2dc69f25e0e3e1f01fd413e0
> Author: Chris Lamb <la...@debian.org>
> Date: Sat Jan 6 23:00:35 2018 +0000
>
> Check for packages that should specify Rules-Require-Root. (Closes:
> #886479)
>
> checks/control-file.desc | 13 +++++++++++++
> checks/control-file.pm | 19 ++++++++++++++++++-
> debian/changelog | 3 +++
> 3 files changed, 34 insertions(+), 1 deletion(-)
>
>
> Regards,
>
Hi,
Thanks for the draft. :)
I got a few remarks:
* check_rules_requires_root appears to be a dead sub (probably
left-over code in your prototype)
* I would probably use $group->get_binary_processables as that
also includes udebs (which technically also triggers the
requirement).
* I think Severity should be at most wishlist for packages without
an explicit Rules-Requires-Root. For packages with an explicit
R³ field, I could agree that it would make sense to have it higher
(except that would almost certainly FTBFS so I doubt the incorrect
value would survive very long anyway)
* I will leave the choice of Certainty to you. That said, "wishlist"
is not valid.
* The tag description should probably mention that we are doing this to
be able to change the default for "Rules-Requires-Root" as the vast
majority of packages are assumed not to require (fake)root.
Thanks,
~Niels
