severity 886670 normal
unblock 883986 by 886670
tag 886670 upstream
forwarded 886670 https://github.com/CGAL/cgal/issues/2734
thanks

On 08.01.2018 20:35, Adrian Bunk wrote:
> While looking into fixing #883986 I ran into the following problem
> due to openscad using CGAL_CXX_FLAGS_INIT:
> 
> /usr/lib/x86_64-linux-gnu/cmake/CGAL/CGALConfig.cmake:
> set(CGAL_CXX_FLAGS_INIT                   "-g -O2 
> -fdebug-prefix-map=/build/cgal-d6DBFP/cgal-4.11=. -fstack-protector-strong 
> -Wformat -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 
> -frounding-math" )
> 
> The only flag that might be correct in this place is -frounding-math,
> in case that is required for using CGAL.
> 
> Exposing flags like -fdebug-prefix-map is simply wrong.
> 
> (For #883986 the problem is the -g, that is also wrong here.)

I agree and I have forwarded this as
https://github.com/CGAL/cgal/issues/2734

> The severity might seem inflated, but this should be fixed
> for fixing the RC #883986 FTBFS in openscad.

However, I disagree about the severity. Since there is a simple workaround I've
reset the severity to normal and removed the block relation.

  Joachim

Reply via email to