Package: claws-mail-pgpmime
Version: 3.16.0-1
Severity: normal
Tags: patch upstream
Dear Maintainer,
when receiving a mail with a correct signature from an
untrusted/unverified key in your keyring, claws-mail displays the text
'Good signature from ...' next to a green padlock icon. This is very
misleading as it looks exactly as one would expect a correct signature
from a verified pgpkey should look. I suggest to change this to the
following new classification of key validity:
diff --git a/src/plugins/pgpcore/sgpgme.c b/src/plugins/pgpcore/sgpgme.c
index 11bd25bfe..165fc81bf 100644
--- a/src/plugins/pgpcore/sgpgme.c
+++ b/src/plugins/pgpcore/sgpgme.c
@@ -114,6 +114,7 @@ SignatureStatus
sgpgme_sigstat_gpgme_to_privacy(gpgme_ctx_t ctx, gpgme_verify_re
return SIGNATURE_INVALID;
case GPGME_VALIDITY_UNKNOWN:
case GPGME_VALIDITY_UNDEFINED:
+ return SIGNATURE_WARN;
case GPGME_VALIDITY_MARGINAL:
case GPGME_VALIDITY_FULL:
case GPGME_VALIDITY_ULTIMATE:
@@ -279,7 +280,7 @@ gchar *sgpgme_sigstat_info_short(gpgme_ctx_t ctx,
gpgme_verify_result_t status)
case GPGME_VALIDITY_NEVER:
default:
if (key) {
- result = g_strdup_printf(_("Good
signature from \"%s\""), uname);
+ result = g_strdup_printf(_("Good
signature from \"%s\" [untrusted key]"), uname);
} else {
result = g_strdup_printf(_("Key 0x%s not
available to verify this signature"), sig->fpr);
}
-- System Information:
Debian Release: buster/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'stable')
Architecture: amd64 (x86_64)
Kernel: Linux 4.14.0-3-amd64 (SMP w/8 CPU cores)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8),
LANGUAGE=de_DE.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages claws-mail-pgpmime depends on:
ii claws-mail 3.16.0-1
ii libassuan0 2.5.1-1
ii libatk1.0-0 2.26.1-3
ii libc6 2.26-5
ii libcairo2 1.15.8-3
ii libcurl3-gnutls 7.57.0-1
ii libdb5.3 5.3.28-13.1+b1
ii libenchant1c2a 1.6.0-11.1
ii libetpan20 1.8.0-1
ii libexpat1 2.2.5-3
ii libfontconfig1 2.12.6-0.1
ii libfreetype6 2.8.1-1
ii libgdk-pixbuf2.0-0 2.36.11-1
ii libglib2.0-0 2.54.3-2
ii libgnutls30 3.5.17-1
ii libgpg-error0 1.27-5
ii libgpgme11 1.10.0-1
ii libgtk2.0-0 2.24.32-1
ii liblockfile1 1.14-1.1
ii libpango-1.0-0 1.40.14-1
ii libpangocairo-1.0-0 1.40.14-1
ii libpangoft2-1.0-0 1.40.14-1
ii libsasl2-2 2.1.27~101-g0780600+dfsg-3
ii zlib1g 1:1.2.8.dfsg-5
Versions of packages claws-mail-pgpmime recommends:
ii pinentry-gnome3 [pinentry-x11] 1.0.0-3
ii pinentry-gtk2 [pinentry-x11] 1.0.0-3
Versions of packages claws-mail-pgpmime suggests:
ii gnupg-agent 2.2.4-1
ii gpg-agent [gnupg-agent] 2.2.4-1
-- no debconf information
