On Thu, Feb 01, 2018 at 02:37:13AM +0100, Guillem Jover wrote:
> > I'd like for dpkg-source to mention that it detected an .asc (probably
> > another "using existing" line?)
> 
> Right! Fixed this now locally.

Thanks!
(shouldn't you `tag -1 pending` this bug?)

> > On a related note, what does that "info: applying version" line mean? :)
> 
> Ah, that'd be a patch called just «version». :)

Ahhhh stupid me.  Of course!
I see that line so many times that I forgot dpkg-source mentions patches
applied/unapplied…

> Perhaps a lintian check is in order?

To have peple call the patch files with a .diff or .patch extension?
I'd rather not, let's not introduce unecessary requirements.
This one was just me using a really generic name, but I tend to use
patch files 'fix_ftbfs_with_boost1.58' without .diff/.patch, and I find
them fine.


> I might try to improve the message, the problem is that too much text
> will make the line wrap, and for common cases with things like fo
> .diff or foo.patch saying something like:
> 
>   dpkg-source: info: applying patch "foo.patch"
> 
> would seem also a bit redundant?

Right.  Just forget and leave it there :)

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-

Attachment: signature.asc
Description: PGP signature

Reply via email to