Control: tags -1 moreinfo Sebastian Kuzminsky kirjoitti 26.01.2018 klo 20:15: > Dear Mentors/Sponsors, > > I am looking for a Sponsor for my package "dxf2gcode":
Here's my short review of the package, but I can't sponsor it. I'm afraid the package cannot be built twice in a row (build log attached), which indicates that the clean target is not functioning as it should. (The relevant Debian Policy chapter is 4.9.) One way to make the cleaning adequate is in build_twice.diff. I added a patch to disable the pylupdate part because it is modifying the *.ts files which is a bit problematic from our POV. If you go that route, I suggest asking upstream to provide a way to disable pylupdate, in order to keep Debian-specific changes to a minimum. Have you forwarded 0001-install-AppStream-metadata-in-the-correct-directory.patch upstream? Please also use DEP3 to document it in the patch file. http://dep.debian.net/deps/dep3/ You have build-depends qt4-linguist-tools, which seems to work, but Qt5 linguist tools are in qttools5-dev-tools as indicated by this search: https://packages.debian.org/file:lrelease When you have resolved these, you can remove the moreinfo tag from the RFS. Regards, Juhani
20180201_twice.build
Description: application/extension-build
diff -Nru dxf2gcode-20170925/debian/patches/no-lupdate.patch dxf2gcode-20170925/debian/patches/no-lupdate.patch
--- dxf2gcode-20170925/debian/patches/no-lupdate.patch 1970-01-01 02:00:00.000000000 +0200
+++ dxf2gcode-20170925/debian/patches/no-lupdate.patch 2018-02-01 18:24:20.000000000 +0200
@@ -0,0 +1,13 @@
+--- a/make_tr.py
++++ b/make_tr.py
+@@ -72,8 +72,8 @@
+ OPTIONS = "-ts"
+
+ cmd1 = ("%s %s %s %s\n" % (PLYPATH, FILESSTR, OPTIONS, TSFILESTR))
+-print(cmd1)
+-print(subprocess.call(cmd1, shell=True))
++#print(cmd1)
++#print(subprocess.call(cmd1, shell=True))
+
+ cmd2 = ("%s %s\n" % (LREPATH, TSFILESTR))
+ print(cmd2)
diff -Nru dxf2gcode-20170925/debian/patches/series dxf2gcode-20170925/debian/patches/series
--- dxf2gcode-20170925/debian/patches/series 2018-01-26 07:53:27.000000000 +0200
+++ dxf2gcode-20170925/debian/patches/series 2018-02-01 18:24:20.000000000 +0200
@@ -1 +1,2 @@
0001-install-AppStream-metadata-in-the-correct-directory.patch
+no-lupdate.patch
diff -Nru dxf2gcode-20170925/debian/rules dxf2gcode-20170925/debian/rules
--- dxf2gcode-20170925/debian/rules 2018-01-26 07:57:51.000000000 +0200
+++ dxf2gcode-20170925/debian/rules 2018-02-01 18:24:20.000000000 +0200
@@ -24,6 +24,12 @@
# dh_auto_configure -- # -DCMAKE_LIBRARY_PATH=$(DEB_HOST_MULTIARCH)
override_dh_auto_clean:
+ python3 st-setup.py clean -a
+ rm -rf dxf2gcode_images5_rc.py \
+ dxf2gcode_ui5.py \
+ dxf2gcode.egg-info/ \
+ globals/__pycache__/ \
+ i18n/*.qm
override_dh_auto_build:
./make_tr.py
