Package: release.debian.org Severity: normal Tags: stretch User: release.debian....@packages.debian.org Usertags: pu
As reported in #888586 quotacheck may run into an endless loop because it fails to honor the non-interactive flag and still asks a question while there is no way to answer it. The proposed patch is already in Sid waiting to migrate to testing. I think we should update stable, too. Therefore this report. The proposed patch is attached. Please tell me what you think. Also, I'm undecided as to whether we should update Jessie which is almost EOL. Any comment on that would be appreciated too. Michael -- System Information: Debian Release: buster/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'stable'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.14.0-3-amd64 (SMP w/4 CPU cores) Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=de_DE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled
commit 09f618d4ed6eee2f2eda3fe069e1de30a7c1e8a6 Author: Michael Meskes <mes...@debian.org> Date: Sat Feb 3 09:46:32 2018 +0100 Prevent quotacheck from running into an endless loop. See #888586 for details. diff --git a/debian/changelog b/debian/changelog index c186840..63f8d28 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,10 @@ +quota (4.03-2+deb9u1) stretch; urgency=medium + + * Prevent quotacheck from running into an endless loop. + See #888586 for details. + + -- Michael Meskes <mes...@debian.org> Sat, 03 Feb 2018 09:45:50 +0100 + quota (4.03-2) unstable; urgency=medium * With systemd only test after installation, the rest is handled by systemd. diff --git a/debian/patches/loop.diff b/debian/patches/loop.diff new file mode 100644 index 0000000..66d739e --- /dev/null +++ b/debian/patches/loop.diff @@ -0,0 +1,14 @@ +#Description: Prevent quotacheck from going into en endless loop. +#Author: Christoph Biedl <debian.a...@manchmal.in-ulm.de> +--- a/quotacheck_v2.c ++++ b/quotacheck_v2.c +@@ -363,7 +363,7 @@ + "specified on command line (%d). Quota file header " + "may be corrupted.\n"), + le32toh(head.dqh_version), version); +- if (!ask_yn(_("Continue checking assuming version from command line?"), 1)) ++ if ((flags & FL_INTERACTIVE) && !ask_yn(_("Continue checking assuming version from command line?"), 1)) + return -1; + detected_versions[type] = version; + } else + diff --git a/debian/patches/series b/debian/patches/series index a348ff0..b9712b6 100644 --- a/debian/patches/series +++ b/debian/patches/series @@ -1 +1,2 @@ editor.diff +loop.diff