Hi, On 07/02/18 21:39, Marc Becker wrote: > Package: mpv > Version: 0.23.0-2+deb9u1 > Followup-For: Bug #888654 > > Patch to line 264 via 08_ytdl-hook-whitelist-protocols.patch is incorrect, > check is applied to raw Youtube ID instead of valid url and always fails as > a result. > > Suggestions: no checking of raw IDs (skipped in upstream fix as well)
Yes I think you're right. It's also broken in sid too (but not in
experimental). I think I got thrown off by newer mpv distinguishing
between youtube ids and non youtube ids.
The original fix for 0.29 adds:
if not site:find("://") then
table.insert(playlist, "ytdl://" .. site)
elseif url_is_safe(site) then
table.insert(playlist, site)
end
So maybe this will work (replacing the existing playlist= assignment):
if not site:find("://") then
playlist = playlist .. "ytdl://" .. site .. "\n"
elseif url_is_safe(site) then
playlist = playlist .. site .. "\n"
end
Thanks,
James
signature.asc
Description: OpenPGP digital signature
