Package: resiprocate-turn-server
Version: 1:1.11.0~beta1-3
Severity: serious
User: [email protected]
Usertags: needed-by-DSA-Team
X-Debbugs-Cc: [email protected]
Hi,
your init script "stop" action is broken.
stop)
log_daemon_msg "Stopping $DESC ($NAME)" $BIN
if start-stop-daemon --stop --quiet --oknodo --user $USER --pidfile
$PIDFILE --exec $DAEMON ;
then
log_end_msg 0
else
log_end_msg 1
fi
;;
It is missing the --retry option which means it doesn't wait until the
process is actually dead before exiting. This shows up in the "restart"
action with:
restart)
$0 stop && sleep 2 && $0 start
;;
That "sleep" is evidence that "stop" is broken.
And because systemd never calls the init script with "restart" but uses
"stop" followed by "start" (which is supposed to be the same thing), the
old "sleep" workaround for broken "stop" no longer works. Please add
the appropriate "--retry" option to "stop" and remove that "sleep".
Cheers,
Julien
