On Sun, Jan 14, 2018 at 08:09:16PM +0100, Helmut Grohne wrote:
> Package: puppet-module-swift
> /usr/share/puppet/modules.available/swift/manifests/storage/ext4.pp contains 
> mkfs.ext4. According to file it is a ASCII text


The above looks like using the mkfs.ext4 command is a crutial part of
the functionality provided by this file.

I can't find anything else in the source that points to this file
actually being used anywhere.

As a comparison there's also a xfs.pp in the same directory, but the
package does not declare any relationship against xfsprogs.

I have no puppet knowledge so it's very hard for me to tell what
the correct solution is. Judging from the first part above
I'd probably lean towards "better safe then sorry -> add e2fsprogs dep",
but given the xfs comparison I'm torn....

Would be great to hear the maintainers view on this!

Andreas Henriksson

Reply via email to