Package: node-evp-bytestokey
Version: 1.0.3-2
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu bionic ubuntu-patch autopkgtest
Hi Bastien,
I see that you've made changes to the autopkgtest in the node-evp-bytestokey
1.0.3-2 upload to experimental. I've tested this version in Ubuntu, and it
still fails in multiple ways:
- the runtestsuite test tries to 'cp -r build', but that does not exist as a
source directory.
- the runtestsuite test runs sed over the tests so that we are testing the
installed version of evp_bytestokey; however, the name used for the
require() call does not match the name under which it's installed as a
package ('-' vs. '_').
- the build-dependency on libssl1.0-dev has been dropped, but you still have
a test dependency on libssl1.0-dev - this is impossible to coinstall with
newer nodejs-dev.
- you have dropped the test dependency on node-gyp, however you are still
explicitly invoking gyp in the test.
I have uploaded the attached patch to Ubuntu, which I believe fixes these
issues.
Thanks for considering,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
[email protected] [email protected]
diff -Nru node-evp-bytestokey-1.0.3/debian/tests/control
node-evp-bytestokey-1.0.3/debian/tests/control
--- node-evp-bytestokey-1.0.3/debian/tests/control 2017-12-30
02:58:44.000000000 -0800
+++ node-evp-bytestokey-1.0.3/debian/tests/control 2018-02-20
12:56:52.000000000 -0800
@@ -5,6 +5,6 @@
Depends: node-evp-bytestokey
, node-bindings (>= 1.2.1)
, node-nan (>= 2.4.0)
- , libssl1.0-dev
, node-tape (>= 4.6)
, build-essential
+ , node-gyp
diff -Nru node-evp-bytestokey-1.0.3/debian/tests/runtestsuite
node-evp-bytestokey-1.0.3/debian/tests/runtestsuite
--- node-evp-bytestokey-1.0.3/debian/tests/runtestsuite 2017-12-30
02:58:44.000000000 -0800
+++ node-evp-bytestokey-1.0.3/debian/tests/runtestsuite 2018-02-20
12:54:13.000000000 -0800
@@ -5,7 +5,7 @@
V=1
export V
-PACKAGE="evp-bytestokey"
+PACKAGE="evp_bytestokey"
SEDCMD="s,require(['][.][.]/?['],require('$PACKAGE',g"
tmpdir=$(mktemp -d)
@@ -18,7 +18,6 @@
cp -r test "$tmpdir"
cp binding.gyp "$tmpdir"
-cp -r build "$tmpdir"
cp package.json "$tmpdir"
