Hi Liubov, On Tue, Mar 13, 2018 at 08:18:15PM +0000, Liubov Chuprikova wrote: > > I have just added an autopkgtest to *coils* (commit > <https://salsa.debian.org/med-team/coils/commit/83773ecf79f48c10b59f6c81d5892b2478c3da2b>).
Thanks a lot. > Could you, please, take a look at it and help me with a few questions I > have about the process: > > 1. I noticed that tests usually try to run a program using test data > from a package and check for errors. There was one in *coils* > available and I used it in my autopkgtest. Very sensible. > Is it enough to check that > the program runs without errors or it would be preferable to check if the > output is correct (there is a sample output in *coil's* Readme)? We try to test as best as possible. In other words: Comparing with a known expected output would be better than just running the program. > 2. Was I right by indicating "Team upload" in *debian/changelog* or it > should be NMU? Team upload is perfect. > 3. What would be my next step? Should I find a sponsor? I'll sponsor the package once you implemented the comparison you mentioned above. > I would really appreciate any feedback you can give me. Thanks a lot for your work on this test. You have proven that you understood how this works. I commited another change with the commit description Install run-unit-test in user visible doc directory to enable users reproducing the test on their local machine and add README.test to explain how this works. That's cosmetics but I consider this an interesting feature for our users. Kind regards Andreas. -- http://fam-tille.de