Package: dh-autoreconf
Version: 16
Severity: wishlist

Dear Maintainer,

Please consider adding support for packages which make use of XDT_* features, 
using xdt-autogen.

As it stands, any Xfce package using dh 10 or above must override dh_autoreconf 
with 'NOCONFIGURE=1 dh_autoreconf xdt-autogen' which is not known by all DDs 
and may lead to bugs such as #870420.

An functional example patch inline below.


--- a/dh_autoreconf     2017-03-31 12:13:10.000000000 -0400
+++ b/dh_autoreconf     2018-02-14 18:36:41.665562722 -0500
@@ -154,9 +154,17 @@
 eval {
     # Run autoreconf to recreate the needed files.
     my $pwd = getcwd();
+    my $dir = '.';
     chdir $opt_sourcedir if (defined($opt_sourcedir) && !compat(9));
 
-    @ARGV ? doit(@ARGV, @{$dh{U_PARAMS}}) : doit('autoreconf', '-f', '-i', 
@directories);
+    if (@ARGV) {
+        doit(@ARGV, @{$dh{U_PARAMS}});
+    } elsif (complex_doit("grep -q '^XDT_' ${dir}/configure.ac 
${dir}/configure.in")) {
+        $ENV{NOCONFIGURE}='1';
+        doit('xdt-autogen', @directories);
+    } else {
+        doit('autoreconf', '-f', '-i', @directories);
+    };
 
     chdir $pwd;
     1;



-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (500, 'testing'), (100, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 4.14.0-3-686-pae (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages dh-autoreconf depends on:
ii  autoconf   2.69-11
ii  automake   1:1.15.1-3
ii  autopoint  0.19.8.1-4
ii  debhelper  11.1.5
ii  libtool    2.4.6-2
ii  perl       5.26.1-5

dh-autoreconf recommends no packages.

dh-autoreconf suggests no packages.

-- no debconf information

Reply via email to