Package: fio Version: 3.1-1 Severity: wishlist sitsofe provided various suggestions and comments in an github issue¹. This is a copy of it, in order to reference it in the changelog of the package. I disabled issues on the github mirror of the packaging repo in order to encourage people to use the Debian bugtracker. Putting all the comments in one bug report to save the time.
[1] https://github.com/teamix/fio-debian/issues/1 Thank you sitsofe for those suggestions. sitsofe commented on 2 Nov 2017: - https://github.com/teamix/fio-debian/blob/master/debian/patches/fix-ftbfs-with-libmtd.h looks redundant now. - https://github.com/teamix/fio-debian/blob/master/debian/patches/makefile-hardening is interesting. Red Hat took a different approach of disabling all optimisations and then using EXTFLAGS - https://src.fedoraproject.org/rpms/fio/blob/b2a49f5d98c612228ba34fc9018a1ecd72472590/f/fio.spec#_35 (I'm just noting the different approach - I'd say there's is slightly more risky but didn't require a patch...) - https://github.com/teamix/fio-debian/blob/master/debian/patches/reproducible-build Making the build reproducible should already in there via axboe/fio@785e49c for 3.1 and later. - One potential suggestion - did you want to ship the fio.service off to the "installable services" location so systemctl enable works? sitsofe commented on 4 Nov 2017: One more suggestion - if you have the flex and bison packages available at build time fio will gain the ability to perform some arithmetic operations (http://fio.readthedocs.io/en/latest/fio_doc.html#job-file-parameters ). I would guess these could go in the Build-Depends line of https://github.com/teamix/fio-debian/blob/master/debian/control . sitsofe commented on 5 Nov 2017: - You may want to add libnuma-dev to the Build-Depends so NUMA control is available (see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=861554 but there's a warning there it's not available on all platforms). - You may want to optionally add glusterfs-common to Build-Depends so the Gluster ioengine is built. - I don't know if it's possible but you may want to make some existing Build-Depends optional dependent on the platform (e.g. there's no libaio-dev package on non-Linux platforms like HURD or kFreeBSD - https://buildd.debian.org/status/package.php?p=fio&suite=unstable ). - You probably want export V = 1 in the debian/rules file otherwise make won't show much compiler output. This would address the compiler-flags-hidden build warning mentioned on https://qa.debian.org/bls/packages/f/fio.html . Thanks, Martin -- System Information: Debian Release: buster/sid APT prefers unstable APT policy: (500, 'unstable'), (200, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.16.0-rc6-tp520-btrfstrim-nolpm-quiescev2+ (SMP w/4 CPU cores; PREEMPT) Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE= (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages fio depends on: ii libaio1 0.3.111-1 ii libc6 2.27-2 ii libibverbs1 17.1-1 ii librados2 10.2.5-7.2 ii librbd1 10.2.5-7.2 ii librdmacm1 17.1-1 ii python 2.7.14-4 ii zlib1g 1:1.2.8.dfsg-5 fio recommends no packages. Versions of packages fio suggests: ii gfio 3.5-1 ii gnuplot 5.2.2+dfsg1-2 ii gnuplot-qt [gnuplot] 5.2.2+dfsg1-2 ii python-scipy 0.19.1-2 -- no debconf information
