tags 354780 + patch thanks Roger Leigh <[EMAIL PROTECTED]> writes:
> Steve Langasek <[EMAIL PROTECTED]> writes: > >> If an schroot process is killed with -HUP (caused, e.g, by a shell being >> terminated by an ssh timeout or my laptop crashing due to the evils of >> NDISWRAPPER), the login session is not cleaned up. This potentially leaves >> many bind mounts, lv snapshots, etc. that must be cleaned by hand. >> >> Please trap SIGHUP in schroot and handle it as you handle other session >> terminations. > > Please could you try > http://people.debian.org/~rleigh/schroot-0.2.6.tar.bz2 and see if this > handles it acceptably? > > I'm afraid there's no patch, because alioth CVS is down. The patch is now attached (against current CVS). I'm not catching SIGHUP at all times, just during the time the session is actually running, which is the only point we should need to do cleanup. We handle SIGHUP for the entirely of session duration (run_impl in schroot/sbuild-session.cc), but only check for it while waiting for child processes (both commands and setup/exec scripts). I think this is OK, but if you think there's a better way of doing this, I'd be happy to look at it again. Regards, Roger -- Roger Leigh Printing on GNU/Linux? http://gutenprint.sourceforge.net/ Debian GNU/Linux http://www.debian.org/ GPG Public Key: 0x25BFB848. Please sign and encrypt your mail.
schroot-sighup-handling.diff.bz2
Description: SIGHUP handling for sessions
pgpF8UpYbevI7.pgp
Description: PGP signature
