On Wed, Feb 21, 2018 at 08:33:02PM +0100, Thorsten Glaser wrote:
I’ve just got hit *again* by this… this time on a
long due wheezy to jessie upgrade.
Multiple issues, I'm afraid.
* I haven't gotten to a jessie update yet - only sid and stretch so far.
* My patch missed several occurrences of "| while read suffix". I think
the one you attached has all of them. I don't know what I was thinking
but I must have failed to test a case involving a dump/reload (as with
wheezy->jessie).
* The grep change I applied doesn't work anyway for jessie and later,
because the patterns gained an anchor in #723957. The command:
grep -Fl "^olcSuffix: $1"
obviously doesn't work. What I actually wanted is probably more like:
grep -Flx "olcSuffix: $1"
Not only does this imply I failed to test a dump/reload upgrade, but
it looks like I _also_ broke update_permissions() for affected
suffixes. Shame on me!
Now wheezy->jessie was the last upgrade where dump/reload was mandatory,
so most users of newer systems wouldn't hit this, but it can be
reproduced by setting slapd/dump_databases: always.
Reopened for fixing properly...
