On Thu, Mar 29, 2018 at 11:31 AM, Theppitak Karoonboonyanan <theppi...@gmail.com> wrote:
> Meanwhile, the existing trie_state_get_data() does exactly > the same to a *terminal* state, but not to a non-terminal one. > If something is still missing, we had better fix it there, > rather than introducing a new similar API. Update: After reading the patch again, I think I got another point: trie_state_get_data() fails when s->is_suffix is FALSE, which the proposed trie_state_get_terminal_data() tries to address. So, I've fixed the issue in trie_state_get_data() instead: https://github.com/tlwg/libdatrie/commit/d1dfdb831093892541cae46eba82c46aec94f726 I'll also inform Filip to check this out before releasing a new upstream version. Best regards, -- Theppitak Karoonboonyanan http://linux.thai.net/~thep/
