Hi Ximin, On 04/18/18 18:40, Ximin Luo wrote: [...] > > Your perl/python tests miss the point. I think it's fine for .encode() to > crash or raise an exception when given an unrecognised encoding, because it's > an explicit command. I don't think it's fine for LC_ALL to crash or raise an > exception, because it's meant to be an opportunistic override. >
Yeah, you're right about the test I sent before. I'm sorry I am not a Perl expert. But take a look at this, please $ apt-get install locales-all -y # It's important having all locales installed because this is what reprotest does and also the way to reproduce the error $ LC_ALL=kk_KZ.XXXXXX perl -e 'use open IO => ":locale"; print "yes\n"' perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = "de:de_DE", LC_ALL = "kk_KZ.XXXXXX", LANG = "de_DE.UTF-8" are supported and installed on your system. perl: warning: Falling back to a fallback locale ("de_DE.UTF-8"). yes $ LC_ALL=kk_KZ.RK1048 perl -e 'use open IO => ":locale"; print "yes\n"' Cannot find encoding "RK1048" at /usr/share/perl/5.26/open.pm line 126. Cannot find encoding "RK1048" at /usr/share/perl/5.26/open.pm line 134. $ LC_ALL=kk_KZ.RK1048 help2man Unknown encoding 'RK1048' at /usr/bin/help2man line 56. > They work fine on my computer but since I was unable to reproduce the bug > here anyways, I am not sure if it means much. But these tests are more "to > the point" than your tests in your output.txt. > I guess you couldn't reproduce it because you don't have locales-all package installed > IMO the time spent discussing this on this bug report would have been better > spent writing patches for the affected programs. > Sorry if you feel discussing this is a waste of time :(. IƱaki already reported it[0] some time ago. But here, we are trying to "fix" reprotest because it's easier than waiting for all the other projects that are failing with this encoding. Just that. > I really don't think reprotest should be coded to ignore known problems. If > you want to avoid these bugs (in other programs), give `reprotest > --vary=-locales` then the problem is evident visually on the command-line and > not "brushed under the carpet" and you can still continue with your other > tests. > Totally agree with you. But just to see if we are on the same page... You are saying that reprotest will fail with a lot of packages if you don't pass `--vary=-locales` because Perl and Python2 are broken, well I wouldn't say broken but they don't support the encoding that reprotest is using for testing random locales. I thought that choosing another encoding in reprotest was reasonable because a lot of packages will fail if you try to use reprotest for this. We got 2 of 3 packages broken by this. Anyway, we are going to report this bug to the packages that don't support the encoding in order to be able to use reprotest, I hope it doesn't take long. Thank you for spending time on this. [0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=894126 -- TiN
signature.asc
Description: OpenPGP digital signature