On Tue, 15 May 2018 at 08:14:00 -0400, Corey Bryant wrote: > On Tue, May 15, 2018 at 5:19 AM, Simon McVittie <[email protected]> wrote: > > > On Tue, 15 May 2018 at 08:46:24 +0000, [email protected] wrote: > > > * Apply debdiff from Ubuntu (Closes: #898663): > > > - d/p/fix-test-run.py.patch: Dropped. No longer needed. > > > > This part seemed OK, but the changelog is a bit misleading: "no longer > > applied since x.y.z" would perhaps be better? > > > I don't know that I'd call this changelog message misleading. With the > current package version, the tests now run successfully without this patch.
Sure, but if you look closely at the patch you sent, the line you're removing from debian/patches/series was commented out - so the patch already wasn't being applied, and the Ubuntu change was just deletion of dead code. I'd normally expect "Dropped. No longer needed" to mean the patch had been applied in the version before this one. It seems that the functional change happened in https://salsa.debian.org/openstack-team/python/python-testtools/commit/bf0343e2527eaa9373ffd03d68a3cd559065a613 which was released as part of 2.3.0-1, so I'd tend to phrase that change more like - d/p/fix-test-run.py.patch: Delete, no longer applied since 2.3.0-1 Regards, smcv
