Hello, Steve

thanks for your quick reply.

Steve Langasek <vor...@debian.org> hat am 25. Mai 2018 um 08:04 geschrieben:


Control: tags -1 moreinfo unreproducible
Control: severity -1 normal

On Fri, May 25, 2018 at 02:23:07AM +0200, Jonathan Dumke wrote:
Source: freetype
Version: 2.8.1
Severity: serious
Justification: fails to build from source (but built successfully in the past)
Dear Maintainer,
I initiated an adopted build

"adopted"?

"Adopted" seems to be the wrong word, but I didn't get a better one last night to discribe what apt-build does. Now I'd say "local build".

of package in question with folowing commandline: apt-build -t testing--build-only install freetype
All went fine, until folowing error occurs:
/var/cache/apt-build/build/freetype-2.8.1/freetype-2.8.1/src/sfnt/ttcmap.c: In function 'tt_get_glyph_name':
/var/cache/apt-build/build/freetype-2.8.1/freetype-2.8.1/src/sfnt/ttcmap.c:3648:12: error: 'PSname' may be used uninitialized in this function [-Werror=maybe-uninitialized]
return PSname;
^~~~~~
In consequence the complete build failed.

I am not able to reproduce this failure using the stock Debian source
package and a standard Debian unstable build environment. I am therefore
downgrading the severity of this report. If this is a modified source
package, please make that clear so that this bug report can be closed as
invalid. If you are reproducing this failure with an unmodified freetype
source package, please provide a complete build log for your failure,
including information about the versions of all build-dependencies installed
in the environment.

No, I left the compiled sources untouched. All dependencies were downloaded from testing.

In a second copy of the orig.tar.gz I examined the cause of error:

In file freetype-2.8.1/freetype-2.8.1/src/sfnt/ttcmap.c the function in lines 3639 until 3649:

FT_CALLBACK_DEF( const char * )
3640 tt_get_glyph_name( TT_Face face,
3641 FT_UInt idx )
3642 {
3643 FT_String* PSname;
3644
3645
3646 tt_face_get_ps_name( face, idx, &PSname );
3647
3648 return PSname;
3649 }

The compiler creates an error in fact of returning a possibly uninitialized variable.

Modifying line 3643 to : FT_String* PSname = NULL;  should fix the problem.

-- Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer https://www.debian.org/
slanga...@ubuntu.com vor...@debian.org

Greetings,

Jonathan

Reply via email to