On Wed, May 30, 2018 at 01:40:48PM +0300, Dmitry Eremin-Solenikov wrote: > > 1. README.Debian > > "Library packages should contain libodp-linux.so.FOO" > > It should be "libodp-linux.so.SOVER", which is more precise. > > Hmm. I have checked buster package lists. Only blas/lapack packages > use soname as virtual package name in provides. The rest of packages > use libsomethingSOVER. Wouldn't it be logical to stick to convention > used by the rest of packages?
I checked the Packages.gz file under the dist directory of the archive.
It seems that the reason why BLAS/LAPACK has taken the virtual package
name "libblas.so.3" is due to ambiguity of libblas3, which could be
a real package and a virtual package following that convention at the
same time.
Providing libodp-linux119 and libodp-linux-dev looks good to me.
> New packages are uploaded to mentors.d.n. Hopefully with this upload
> I will have just two remaining issues:
> - manpages
> - dh_auto_test override.
If they are to be fixed in the future uploads, please at least override
the missing-manpage lintian warning, prepending a comment to it.
The empty override_dh_auto_test should have a proper comment too.
> I plan to look onto adding package autotests afterwards.
With those tests the package would be better.
The present package looks good to me[1], except for:
1. [optional] debian/rules: please wrap long lines to 80 characters.
2. [error] libodp-generic119.prerm.in:
update-alternatives --remove \
/usr/lib/@DEB_HOST_MULTIARCH@/libodp-linux.so.@ODP_SOVERSION@ \
libodp-linux.so.@ODP_SOVERSION@-@DEB_HOST_MULTIARCH@ \
/usr/lib/@DEB_HOST_MULTIARCH@/odp-generic/libodp-linux.so.@ODP_SOVERSION@
This is causing a removal failure:
http://debomatic-amd64.debian.net/distribution#unstable/odp/1.19.0.1-1/piuparts
Please fix the aforementioned problems. Hopefully we'll have the last
round of check next time. Thank you for working on this.
[1]
http://debomatic-amd64.debian.net/distribution#unstable/odp/1.19.0.1-1/buildlog
signature.asc
Description: PGP signature
