Bug#900089: [zfs-dkms]

[Chris Dos]

On 05/29/2018 04:14 PM, Antonio Russo wrote:
> Control: severity -1 wishlist
> 
> I think everyone can agree this is at most a wishlist bug.
> 
> I also agree that making Debian packaging easier for others in the greater
> Debian ecosystem would be nice.
> 
> However, your point of contact for a build issue on another distribution
> should be that distribution's bugtracker. Not filing grave bugs without 
> first confirming they affect that distribution.
> 

My apologies for making this grave bug.  I've been building the zfs packages
for upwards of two years now for the sysvinit bug and never had Debian
specific check before.

When I saw the https://github.com/zfsonlinux/zfs/issues/7540 bug where
Serphentas said it had the error on Stretch, I thought it was affecting Debian
and Debian based systems.

I saw the fix in git master, but I still don't see the reason why lsb_release
is used as the test to determine where the kernel source is.  There must be a
better way to test this when using lsb_release.

I've attached a better looking patch that removes the lsb_release check.  I'm
not sure why the other one looked so ugly when I used quilt before.

--- a/debian/zfs-dkms/usr/src/zfs-0.7.9/dkms.conf
+++ b/debian/zfs-dkms/usr/src/zfs-0.7.9/dkms.conf
@@ -6,8 +6,6 @@
   --prefix=/usr
   --with-config=kernel
   --with-linux=$(
-    case `lsb_release -is` in
-      (Debian)
         if [[ -e ${kernel_source_dir/%build/source} ]]
         then
           echo ${kernel_source_dir/%build/source}
@@ -15,11 +13,6 @@
           # A kpkg exception for Proxmox 2.0
           echo ${kernel_source_dir}
         fi
-      ;;
-      (*)
-        echo ${kernel_source_dir}
-      ;;
-    esac
   )
   --with-linux-obj=${kernel_source_dir}
   --with-spl=${source_tree}/spl-${PACKAGE_VERSION}
--- a/debian/zfs-dkms.dkms.debhelper
+++ b/debian/zfs-dkms.dkms.debhelper
@@ -6,8 +6,6 @@
   --prefix=/usr
   --with-config=kernel
   --with-linux=$(
-    case `lsb_release -is` in
-      (Debian)
         if [[ -e ${kernel_source_dir/%build/source} ]]
         then
           echo ${kernel_source_dir/%build/source}
@@ -15,11 +13,6 @@
           # A kpkg exception for Proxmox 2.0
           echo ${kernel_source_dir}
         fi
-      ;;
-      (*)
-        echo ${kernel_source_dir}
-      ;;
-    esac
   )
   --with-linux-obj=${kernel_source_dir}
   --with-spl=${source_tree}/spl-${PACKAGE_VERSION}
--- a/debian/zfs-dkms.dkms
+++ b/debian/zfs-dkms.dkms
@@ -6,8 +6,6 @@
   --prefix=/usr
   --with-config=kernel
   --with-linux=$(
-    case `lsb_release -is` in
-      (Debian)
         if [[ -e ${kernel_source_dir/%build/source} ]]
         then
           echo ${kernel_source_dir/%build/source}
@@ -15,11 +13,6 @@
           # A kpkg exception for Proxmox 2.0
           echo ${kernel_source_dir}
         fi
-      ;;
-      (*)
-        echo ${kernel_source_dir}
-      ;;
-    esac
   )
   --with-linux-obj=${kernel_source_dir}
   --with-spl=${source_tree}/spl-${PACKAGE_VERSION}