Hi, The below mail was sent over two years ago now, and there's been no follow-up from you.
The window for getting fixes into jessie before it becomes LTS closes during the coming weekend. Are you still interested in addressing these issues? Regards, Adam On Wed, 2016-04-06 at 17:51 +0100, Adam D. Barratt wrote: > On 2016-04-06 17:37, Rolf Leggewie wrote: > > On 04.04.2016 16:58, Adam D. Barratt wrote: > > > > I'd like to request to upload a bug-fix for the roger-router > > > > package > > > > to Jessie. This would fix bugs #798471 and #774116. > > > > > > > > Roger Router is a tool to interact with Fritzbox hardware from > > > > AVM. > > > > One of the things it can do is to send a fax. This was broken > > > > until > > > > version 1.8.9-3 because compilation happened as --with-cups-yes > > > > assuming this would include cups-support when in fact this > > > > disabled > > > > a known-good code base for cups-support and replaced it with a > > > > known-broken, experimental one. The patches are cherry-picked > > > > from > > > > 1.8.9-3 and 1.8.9-4. > > > > > > Please provide a source debdiff of the proposed package as built > > > and > > > tested on Jessie, rather than indvidual patches; that's what > > > we'll be > > > acking (or otherwise). > > > > Sure. > > > > I thought the individual patches would be easier to inspect and > > approve/reject as necessary. Attached is a single debdiff. > > For one thing, the debdiff that people provide often doesn't > actually > match the result of simply applying the patches... > > +roger-router (1.8.9-2jessie1) jessie; urgency=medium > > That style of version numbering has been discouraged for at least > two > release cycles now - 1.8.9-2+deb8u1, please. > > + * do not build the experimental (!) cups backend. Closes: #774116 > + Upstream uses a very funny (NOT!) semantics to their make- > switches. > + Who would expect that "--with-cups=yes" actually DISABLES a > working > + cups support? > > I'd prefer if we could drop the commentary here, or at least make > the > description more factual. > > Build-Depends: debhelper (>= 9), dh-autoreconf, > libappindicator3-dev, > libcapi20-dev (>= 1:3.24), > - libcups2-dev, > libebook1.2-dev, > - libgconf2-dev, > > I'm afraid that I'm somewhat confused here. How does building the > CUPS > backend that does work not require development files for CUPS? Why > is > libgconf2-dev dropped? > > --- a/debian/libroutermanager0.symbols > +++ b/debian/libroutermanager0.symbols > @@ -81,7 +81,7 @@ libroutermanager.so.0 libroutermanager0 #MINVER# > fax_send@Base 1.8.4 > fax_set_log_level@Base 1.8.4 > fax_spandsp_workaround@Base 1.8.4 > - fax_spooler_new_dir_cb@Base 1.8.4 > +#MISSING: 1.8.9-2# fax_spooler_new_dir_cb@Base 1.8.4 > fax_transfer@Base 1.8.4 > faxophone_close@Base 1.8.4 > faxophone_connect@Base 1.8.4 > > I realise that libroutermanager0 doesn't have any in-archive users > outside of roger-router itself, but that's surely still an ABI > change. > > Regards, > > Adam > >
