Package: lcdproc
Version: 0.4.5-1
Severity: normal

LCDd can handle widgets on a frame. So one can create a frame 
that is bigger than the actual size of the LCD. LCDd cares about
scrolling the frame withing the display portion. To add a widget
to a frame you have to send "widget_add ... in <frameid>" to the 
server.

The problem is that on the server side in client_functions.c on
line 827 there is a test for "in" - but in the wrong way.

   if (strcmp(p, "in")) {
   
should read
   
   if (0==strcmp(p, "in")) {
   
This means the "in" option is not recognized. In lcdproc
(see mem.c and disk.c) they tried a workaround by using "-in"
instead "in" but this also does not work becaus the "-" char 
is stripped off using a "if (*p=='-') p++;" a few lines above.

diff file would go like:

--- lcdproc-0.4.5/server/client_functions.c_ORG   2004-05-19
13:27:58.000000000 +0200
+++ lcdproc-0.4.5-1/server/client_functions.c    2006-03-04
18:16:54.000000000 +0100
@@ -824,7 +824,7 @@
                        p++;
                        
                                        /* Handle the "in" flag to place 
widgets in a
container...*/
-               if (strcmp (p, "in")) {
+               if (0==strcmp (p, "in")) {
                        if (argc < 6) {
                                sock_send_string (c->sock, "huh? Specify a
frame to place widget in\n");
                                return 0;
                                                                                
                                                
Please note that if LCDd gets fixed do not forget to 
change "-in" to "in" in 
/clients/lcdproc/disk.c and 
clients/lcdproc/mem.c.
also.

Greetings
Andreas

-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.15
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ISO-8859-1)

Versions of packages lcdproc depends on:
ii  debconf     1.4.70     Debian configuration management sy
ii  libc6       2.3.5-13   GNU C Library: Shared libraries an
ii  libncurses5 5.5-1      Shared libraries for terminal hand
ii  libsvga1    1:1.4.3-22 console SVGA display libraries

lcdproc recommends no packages.

-- no debconf information

-- 
Echte DSL-Flatrate dauerhaft für 0,- Euro*!
"Feel free" mit GMX DSL! http://www.gmx.net/de/go/dsl


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to