On Wed, 27 Jun 2018 at 13:44:23 +0200, Fabian Grünbichler wrote: > On Wed, Jun 27, 2018 at 12:56:04PM +0200, Guilhem Moulin wrote: >> On Tue, 26 Jun 2018 at 23:34:20 +0200, Fabian Grünbichler wrote: >>> cryptsetup: ERROR: Couldn't normalise device rpool/ROOT/debian >>> cryptsetup: ERROR: Couldn't find sysfs directory corresponding to >>> rpool/ROOT/debian >> >> I guess you had a fake line for that device in your /etc/fstab and >> that's why up to 2:2.0.3-1 the hook script didn't complain about not >> being able to normalize the device? In that case it's not caused by the >> package split per se, but by the hook using /proc/mounts rather than >> /etc/fstab to find which device is holding / (and /usr). > > no, never had a fake fstab line, there were always warnings about not > being able to detect the device for /, but now they got more verbose and > there are two, so I took the opportunity to file this bug.
:-) > I think I'd prefer a two-step approach: > - warn by default on known non-detectable file system in > get_mnt_devices, pointing to crypttab (to help with initial setup, and > for users that might benefit from this assistance) > - allow silencing of detection warnings (once the setup is known to > work) > > the latter might be a simple on/off switch, or a whitelist of ignored > (i.e., manually setup) filesystems, or a whitelist of ignored (i.e., > manually setup) mountpoints. Makes sense to be able to silence that warning, indeed. There are only two mountpoints we're considering at initramfs stage (/ and /usr), so I'm not sure if fine-grained control is worth to implement. That said it doesn't really add much complexity (fstype and mountpoint are both in scope already), so I don't have hard feelings either way. Cheers, -- Guilhem.
signature.asc
Description: PGP signature
