Package: dovecot
Version: 1:2.3.2-2
Severity: wishlist

Dear Maintainer,

I created a merge request in
https://salsa.debian.org/debian/dovecot/merge_requests/1/ to add more
DEP8 tests to the Dovecot package.

These are DEP8 test that Ubuntu has been carrying as delta from
Debian. I slightly changed them to drop the hardcoded Ubuntu check in
the server banner, and made that distribution agnostic by calling out
to lsb_release. The Dovecot servers do the same when they inject the
distribution name in the banner. This particular change isn't in
Ubuntu yet (there we still have the hardcoded Ubuntu name in the
tests).

I could have gone with a regexp match of the type (Ubuntu|Debian), but
chose to use lsb_release. Let me know if you have a preference.

Here is a dep8 run of debian sid with these changes:
http://people.ubuntu.com/~ahasenack/dep8-dovecot-sid-with-ubuntu-tests/

Also please let me know if you want me to drop the d/changelog entry.
I had to have one for my test builds, and just left it there for this
merge request.

Thanks for you consideration.

Reply via email to