Package: pstack
Version: 1.2-1
Severity: normal
Tags: upstream

In multiple places in the pstack source, errno is checked as an error
indicator, without first checking the retval of the function.  This is
wrong according to the errno manpage:

  Its value is significant only when the call returned an error
  (usually -1), and a function that does  succeed is allowed to change
  errno.

BTW, does pstack still work correctly?

$ pstack 8987

8987: gaim -d
(No symbols found)
0xb77b5d16: ???? (8341a08, 8, 63, 8341a08, 8, 15530) + 40
0xb786ddbc: ???? (8146a48, 1, 81f8a00, 0, bf9b8d88, 8146a48) + 10
0xb786e2c7: ???? (82991e8, 82991e8, 1, 1, 0, 82991e8) + 30
0xb7cc1231: ???? (829ab50, 0, 80f95e0, 80fdabb, 810eab4, 0) + 2170
0x080fa017: ???? (2, bf9baf94, bf9bafa0, 1, b7821ff4, 0) + 30
0xb7703ed0: ???? (80f95f0, 2, bf9baf94, 80fb870, 80fb8e0, b7fb25d0) + 40645077

But gdb shows useful function names:
#0  0xb77b5d16 in poll () from /lib/tls/libc.so.6
#1  0xb786ddbc in g_main_context_check () from /usr/lib/libglib-2.0.so.0
#2  0xb786e2c7 in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
#3  0xb7cc1231 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
#4  0x080fa017 in main (argc=2, argv=0xbf9baf94) at main.c:961

I'd love to be able to not load gdb every time I need a bt, but right
now this isn't useful..  It says that it needs unstripped binaries;
why?


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to