On 2018-07-11 16:38, Sandro Tosi wrote:
control: tags -1 - patch
On Wed, Jul 11, 2018 at 10:29 AM Bas Couwenberg <sebas...@xs4all.nl>
wrote:
On 2018-07-11 16:23, Sandro Tosi wrote:
> On Wed, Jul 11, 2018 at 10:03 AM Bas Couwenberg <sebas...@xs4all.nl>
> wrote:
>> The _geoslib.c file needs to regenerated with a recent Cython to be
>> compatible with Python 3.7.
>
> the attached patch looks it's including only the regenerated files,
> wouldnt it be better to b-d on cython and actual regenerate the .c
> file at debian package build time?
That would be better, but not something I'm willing to spend my time
on.
fair enough, but as is this patch cannot be accepted.
Why not? It works just fine. cythonizing will just need to be done again
in the future.
At least apply the README.md change to debian/docs, that should be
uncontroversial.
I only fixed this issue because it also prevented the rebuild of
basemap
with GEOS 3.7.0 from experimental.
>> Upstream should generate the .c files as part of the build instead of
>> including a pre-generated file in the distribution as a more permanent
>> solution.
>
> could you open an issue upstream for this?
No, please do that yourself as the maintainer of this package.
Kind Regards,
Bas
