# Let's sort things out unmerge 876316 retitle 849782 buggy magic: Does not detect all .apk file (mostly as .zip only) severity 849782 normal thanks
Ximin Luo wrote...
> But it's from the same person and in the same topic ("improving" detection of
> filesystems).
Two stories here: Telling whether a .zip is actually .apk isn't that
easy given file's capabilities, i.e. without parsing the central
directory. This is 849782/849783
Bug 876316 however is a fairly horrible regression: The initial
detection for "DOS/MBR boot sector", introduced in commit
FILE5_11-63-g51ceb2bd is *way* too weak, one in approx. 2^17 files gets
mis-detected this way. But it's still there, I'll try to get that fixed
upstream, it's doable but not that easy without introducing other
regressions.
Christoph
signature.asc
Description: PGP signature
