Control: reassign -1 git-buildpackage 0.8.12.2 Guido: steps to reproduce:
git clone https://salsa.debian.org/benh/sgt-puzzles.git cd sgt-puzzles git checkout -b test.904993 debian/20170606.272beef-1 gbp pq import observe the result, particularly * There is a commit whose subject line is fix-ftbfs-with-gcc-6 but which did have a proper, multi-line, Description. * The other patches have had the puzzla name (first word of the Description) mysteriously removed, eg "_make-more-docs" made from debian/patches/201_make-more-docs.diff. This corruption seems likely to be due to two sequential attempts to strip of a header name. Ben Hutchings writes ("Bug#904993: git-debrebase convert-from-gbp doesn't handle multi-line Description"): > git-debrebase convert-from-gbp failed to convert the headers in the > attached patch: > > gbp:warning: Patch 'fix-ftbfs-with-gcc-6.patch' has no authorship > information, using 'Ben Hutchings <[email protected]>' > > It worked with the other patches using Author and Description header > fields, but I noticed that this is the only one using continuation > lines in the Description. DEP-3 says: This is because git-debrebase is using gbp pq, underneath. gdr convert-from-gbp makes the gdr branch from a (not visible externally) gbp-pq-made patch queue branch. The output includes various complaints about patch authorship information, eg: gbp:warning: Patch '102_fix-pearl-min-dimensions.diff' has no authorship information, using 'Ben Hutchings <[email protected]>' But that doesn't seem to be accurate. The patch file starts like this: Author: Ben Hutchings <[email protected]> Description: pearl: Require width or height to be at least 6 for Tricky Bug-Debian: https://bugs.debian.org/667963 and the generted commits do have the expected author. > "When Subject is used, it is expected that the long description is > outside of the structured fields. With Description it is possible to > embed them in the field using continuation lines." I agree that this should be better. Thanks to both of you for your attention. Ian. -- Ian Jackson <[email protected]> These opinions are my own. If I emailed you from an address @fyvzl.net or @evade.org.uk, that is a private address which bypasses my fierce spamfilter.
