On 2018-07-31 10:46, Philipp Kern wrote:
On 2018-07-31 09:24, Philipp Kern wrote:
I buy the argument for attached removable file systems. It looks like
today fstrim iterates over /proc/self/mountinfo and trims all
non-pseudo/non-netfs. On the other hand enough guides on the internet
say that to have a working system with an SSD, you want to have TRIM.
By
not applying the proper defaults, many users will still enable
fstrim.timer and then not think about it when the recovery/forensic
case
comes along. So this is surprising nonetheless.
It feels like fstrim should have a mode that looks at volumes
referenced
by /etc/fstab (just like mount -a, that it wanted to mimic according
to
the code) instead of the currently mounted filesystems. And then we
actually should enable that by default.
I filed https://github.com/karelzak/util-linux/issues/673 upstream
about this.
And the amazing util-linux upstream author Karel already fixed it in
https://github.com/karelzak/util-linux/commit/c5b8909f13d29d066ee9882fe0e3129d2f3bcffc
and now provides an -A option that just looks at fstab. I guess I'll go
and file a separate bug once that's in a release to make that enabled by
default.
Kind regards
Philipp Kern