Hi, On Thu, Aug 09, 2018 at 10:30:54AM +0100, Chris Lamb wrote: > I just ACCEPTed radare2 from NEW
Thanks. > but was wondering if you could consolidate all of the > DEBUG_SUPPORT conditionals in debian/rules: > > 21 ifeq (i386,$(DEB_HOST_ARCH_CPU)) > 22 DEBUG_SUPPORT=1 > 23 endif > 24 > 25 ifeq (amd64,$(DEB_HOST_ARCH_CPU)) > 26 DEBUG_SUPPORT=1 > 27 endif > 28 > 29 ifeq (mips,$(DEB_HOST_ARCH_CPU)) > 30 DEBUG_SUPPORT=1 > 31 endif > 32 > 33 ifeq (mips64,$(DEB_HOST_ARCH_CPU)) > 34 DEBUG_SUPPORT=1 > 35 endif > > Pretty sure there is a Make construct to do these all at once? :) Make syntax is pretty limited, but it Looks like this may work: ifeq (i386,$(DEB_HOST_ARCH_CPU)) DEBUG_SUPPORT=1 else ifeq (amd64,$(DEB_HOST_ARCH_CPU)) DEBUG_SUPPORT=1 else ifeq (mips,$(DEB_HOST_ARCH_CPU)) ... endif But it's still ugly compared to python style "if $arch in [option1, option2]". I'm open for suggestions :) Note, that it might not be needed anymore once the package switches from radare's custom autoconf-like build system to meson (upstream is currently working on supporting it in parallel). -- Sebastian
signature.asc
Description: PGP signature
