On Thu, Aug 9, 2018 at 11:36 AM Chris Lamb <la...@debian.org> wrote: > > Source: node-toidentifier > Version: 1.0.0-1 > Severity: wishlist > X-Debbugs-CC: Bastien Roucaris <ro...@debian.org>, > ftpmas...@debian.org > > Hi, > > I just ACCEPTed node-toidentifier from NEW but was wondering if: > > ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS) $(DEB_BUILD_PROFILES))) > > .. should really be checking (only) DEB_BUILD_OPTIONS?
It is a feature that dpkg-buildpackage -P nocheck does not set DEB_BUILD_OPTIONS. My solution above is policy compliant and allow to test nocheck with dpkg-buildpackage.... Bastien > > > Regards, > > -- > ,''`. > : :' : Chris Lamb > `. `'` la...@debian.org / chris-lamb.co.uk > `-