On Mon, 2018-08-13 at 15:21 +0200, Agustin Henze wrote:
> Please review if this patch is ok for apply,
It looks like you already committed it?
> it should work ok as far as I
> understand. But it'd be good if someone with experience on perl,
> regex and
> uscan review it carefully.
>
> --- /usr/bin/uscan 2018-08-13 15:12:31.374367891 +0200
> +++ uscan 2018-08-13 15:12:27.758379028 +0200
> @@ -3294,7 +3294,7 @@
> uscan_verbose "Matching pattern:\n @patterns\n";
> }
> my @hrefs;
> - while ($content =~
> m/<\s*a\s+[^>]*href\s*=\s*([\"\'])(.*?)\1/sgi) {
> + while ($content =~
> m/<\s*a[^>]*\s+href\s*=\s*([\"\'])(.*?)\1/sgi) {
I'd re-insert the original spaces. Otherwise you're currently accepting
"<aubergine href=" and the like, which while unlikely is still
incorrect.
Regards,
Adam
