Control: tag -1 +moreinfo

Hi Wolfgang,

Thank you for filing this bug, I'm always happy to hear from users,
and a bug is an opportunity to improve something!

On Mon, Sep 10, 2018 at 08:58:03AM +0100, Wolfgang Weisselberg wrote:
> Package: btrfsmaintenance
> Version: 0.4.1-3
> Severity: normal
> Tags: patch
> 
> Dear Maintainer,
> 
> BTRFS_SCRUB_PRIORITY="idle" (or not setting it at all) in
> /etc/default/btrfsmaintenance should cause
> /usr/share/btrfsmaintenance/btrfs-scrub.sh to start scrub
> with idle IO priority.
> 
> But it starts it with the default IO priority like any other
> job.
> 
> The reason seems to be that the default value for ioprio
> is not set:
[ text from patch and System Information ]

From 'man btrfs-scrub', "The default IO priority of scrub is the idle
class", thus 'btrfs-scrub' should default to the idle class when
$ioprio is nil.

eg:
ioprio=
btrfs scrub start -Bd $ioprio /
# is equivalent to
# btrfs scrub start -Bd /
# which should default to -c 3 (idle)

The idle priority might not be applied for other reasons.  Would you
please share the output to the following commands:

First, please unapply your patch or reinstall btrfsmaintenance, since
it looks like it is applied to /usr/share/btrfsmaintenance/btrfs-scrub.sh

# while a btrfsmaintenance scheduled scrub is running
ionice -p `pidof btrfs-scrub`
# and
cat /sys/block/sd*/queue/scheduler
# and
cat /sys/module/*/parameters/use_blk_mq


Cheers,
Nicholas

Attachment: signature.asc
Description: PGP signature

Reply via email to