Package: aprsd
Version: 2.2.5-13
Severity: minor
Tags: sid, patch, upstream

Hi Hamish,

I'm not sure what the "correct" behaviour is when aprsd uses hub
connections, so this may be a false bug report.

For every non connected hub, aprsd was subtracting one from the
connection count. This lead to having -1 users, with one telnet
user logged on, which certainly wasnt right!

Other comments in the code lead me to believe that the "user"
count "should" include outgoing server/hub/igate connections,
this patch seems to work for hub connections, certainly.


All the Best

Iain


--- aprsd-2.2.5-13/src/servers.cpp      2006-02-28 16:11:08.520805144 +0000
+++ aprsd-2.2.5-13-tst/src/servers.cpp  2006-03-10 15:12:28.511962936 +0000
@@ -502,8 +502,8 @@ int getConnectedClients(void)
             count++;
 
     for (int i = 0; i < nIGATES; i++)
-        if (!cpIGATE[i].connected)
-            count--;
+        if (cpIGATE[i].connected)
+            count++;
 
 
    return count;


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to