Package: libpng
Version: 1.2.8rel-5
Severity: wishlist
Tags: patch, d-i

Let's call this an important wishlist bug (important for Debian Installer 
anyway :-)

Please add the following line to your shlibs file:
udeb: libpng12 0 libpng12-0-udeb (>= 1.2.8rel)

This will allow dpkg/debhelper to properly set the dependencies for udebs 
that depend on libpng.
Please see #345472 and #345475 for further info on this.

It would be very much appreciated if this change could be implemented
soon.


The attached patch implements the necessary changes:
- add --add-udeb option for dh_makeshlibs which autogenerates the
  udeb: lines for the shlibs file
- this requires debhelper 5.0.22
- add the udeb line also to debian/libpng12-0.shlibs as this currently
  overrules whatever is generated by dh_makeshlibs [1]
- drop the Provides: libpng12-0

I've also updated debian/compat to level 5, in line with the debhelper 
dependency.

I've checked the debdiff for the libpng12-0 deb and udeb against current 
versions and there were no unexpected changes.

TIA,
Frans Pop

[1] To be honest I fail to see why you include that file at all: if I
    remove it, the generated shlibs is identical to the one you include.
    Packaging error?
diff -u libpng-1.2.8rel/debian/control libpng-1.2.8rel/debian/control
--- libpng-1.2.8rel/debian/control
+++ libpng-1.2.8rel/debian/control
@@ -2,7 +2,7 @@
 Section: libs
 Priority: optional
 Maintainer: Josselin Mouette <[EMAIL PROTECTED]>
-Build-Depends: debhelper (>= 4.2), zlib1g-dev, cdbs, mawk
+Build-Depends: debhelper (>= 5.0.22), zlib1g-dev, cdbs, mawk
 Standards-Version: 3.6.2
 
 Package: libpng12-0
@@ -49,8 +49,7 @@
 XC-Package-Type: udeb
 Section: debian-installer
 Architecture: any
-Depends: zlib1g-udeb
-Provides: libpng12-0
+Depends: ${shlibs:Depends}
 Description: PNG library - minimal runtime library
  libpng is a library implementing an interface for reading and writing
  PNG (Portable Network Graphics) format files.
diff -u libpng-1.2.8rel/debian/libpng12-0.shlibs libpng-1.2.8rel/debian/libpng12-0.shlibs
--- libpng-1.2.8rel/debian/libpng12-0.shlibs
+++ libpng-1.2.8rel/debian/libpng12-0.shlibs
@@ -1,0 +2 @@
+udeb: libpng12 0 libpng12-0-udeb (>= 1.2.8rel)
diff -u libpng-1.2.8rel/debian/rules libpng-1.2.8rel/debian/rules
--- libpng-1.2.8rel/debian/rules
+++ libpng-1.2.8rel/debian/rules
@@ -29,6 +29,7 @@
 DEB_INSTALL_DOCS_libpng12-dev := --no-act
 DEB_INSTALL_CHANGELOGS_libpng3 := --no-act
 DEB_INSTALL_CHANGELOGS_libpng12-dev := --no-act
+DEB_DH_MAKESHLIBS_ARGS_libpng12-0 := --add-udeb="$(UPACKAGE)"
 
 binary-post-install/libpng12-dev::
 	dh_installdocs -plibpng12-dev -Xcopyright
diff -u libpng-1.2.8rel/debian/compat libpng-1.2.8rel/debian/compat
--- libpng-1.2.8rel/debian/compat
+++ libpng-1.2.8rel/debian/compat
@@ -1 +1 @@
-4
+5

Attachment: pgpUSnyff6DY2.pgp
Description: PGP signature

Reply via email to