Source: golang-defaults
Source-Version: 2:1.10~6
Severity: minor
Tags: patch
Hi!
While going over its sources I noticed the getver.pl script. Here's a
patch with some minor improvements.
Thanks,
Guillem
From 2b4c7ee23dee2a0d2096617daec3fc4470da9480 Mon Sep 17 00:00:00 2001
From: Guillem Jover <gjo...@sipwise.com>
Date: Tue, 25 Sep 2018 21:51:30 +0200
Subject: [PATCH] Improve getver.pl script
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
- Use Dpkg::Changelog::Parse instead of forking off dpkg-parsechangelog.
- Remove now unnecessary Dpkg::Version import.
- Remove redundant «package main».
---
debian/helpers/getver.pl | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/debian/helpers/getver.pl b/debian/helpers/getver.pl
index d54506a..27a87b4 100755
--- a/debian/helpers/getver.pl
+++ b/debian/helpers/getver.pl
@@ -2,13 +2,13 @@
# Extract upstream version from version in changelog.
-package main;
-
use warnings;
use strict;
-use Dpkg::Version;
+use Dpkg::Changelog::Parse;
-my $v = Dpkg::Version->new(`dpkg-parsechangelog -SVersion`)->version();
+my $fields = changelog_parse();
+my $v = $fields->{Version}->version();
$v =~ /^([0-9]+\.[0-9]+).*/ or die 'INVALID VERSION! (needs X.Y)';
+
printf("%s\n", $1);
--
2.19.0
