On 2018-09-28 06:37, Felipe Sateler wrote:
But there are only 2 specific patches needed to fix the strip bug,
https://github.com/NixOS/patchelf/pull/117 [1]
https://github.com/NixOS/patchelf/pull/127 [2]
Can we apply these patches to debian's 0.9 (copy the commits into
debian/patches)? If that builds on all arches then it's a good
resolution for this bug.
I note that a comment in #127 says not all of the problems are
resolved. But if this helps mitigate the problem, I don't have a
problem applying those.
Unfortunately I'm currently a bit lacking on time. Help in the form of
patches welcome, even better if in the form of a salsa MR.
I created branch dparsons/0.9_fix_strip from tag debian/0.9-1 and
applied the patches (refreshed to patch cleanly against 0.9).
I pushed dparsons/0.9_fix_strip to salsa.
I haven't set up an MR since it needs a target branch. The debian branch
is too far ahead (latest git).
We want a branch like 0.9 or debian/0.9, i.e.
git checkout -b 0.9 debian/0.9-1
or git checkout -b debian/0.9 debian/0.9-1
and then we can merge dparsons/0.9_fix_strip into it. I figured I
should let you decide which 0.9 branch to create.
These patches seem to fix the strip problem. The bug I'm addressing is
managing circular dependencies in hypre,
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=902102). This patched
patchelf 0.9 allows the missing needed links to be added to the hypre
libs, without breaking dh_strip.
At the same time, I also tested adding the #127 patch to the debian
branch (i.e. applying it to latest git). It does allow patchelf (latest
git) to pass tests, and still works with hypre. I don't know about any
other unresolved problems, but it fixes what I want for hypre.
So that gives us 2 options for this strip bug
1) merge dparsons/0.9_fix_strip into a branch of debian/0.9-1
- applies 2 small patches only to 0.9
2) add the #127 patch to the debian branch
- applies one new small patch, but also other upstream patches from
git
If you'd like to go ahead with 2), I can create a branch to merge from.
