Package: flashplugin-nonfree
Version: 7.0.61-3
Severity: normal

When I run update-flashplugin, I get:

$ sudo update-flashplugin 
MIRROR_UH = ok
MIRROR_RI = ok
installation failed

When tracing it:

$ sudo sh -x update-flashplugin
[...]
+ mksymlink /usr/lib/flashplugin-nonfree/libflashplayer.so 
/usr/lib/mozilla/plugins/libflashplayer.so
+ '[' -e /usr/lib/flashplugin-nonfree/libflashplayer.so ']'
+ '[' '!' -e /usr/lib/mozilla/plugins/libflashplayer.so ']'
+ return -1
+ FAIL=true
[...]

The problem is that the script thinks that the installation fails if
the symlinks happen to already exist, or the directories don't
exist. This is clearly wrong. The mksymlink() function should be
rewritten to only fail when the symlink can't be created. Something like:

mksymlink() {
        [ -e $1 ] || return -1
        [ ! -e $2 ] || rm $2 || return -1
        [ -d $(dirname $2) ] || mkdir -p $(dirname $2)
        ln -s $1 $2 || return -1
        return 0
}

The mkdir line is needed because flashplugin-nonfree might be
installed prior to the web browser (it doesn't depend on it). This
also means that the directory should be removed when uninstalling,
thus something like

rmdir -p --ignore-fail-on-non-empty $(dirname $2)

should be added to rmsymlink().

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.15-1-686
Locale: LANG=C, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages flashplugin-nonfree depends on:
ii  debconf [debconf-2.0]         1.4.71     Debian configuration management sy
ii  gsfonts-x11                   0.18       Make Ghostscript fonts available t

Versions of packages flashplugin-nonfree recommends:
ii  libstdc++2.10-glibc2.2       1:2.95.4-24 The GNU stdc++ library

-- debconf information:
  flashplugin-nonfree/httpget: true
  flashplugin-nonfree/not_exist:
  flashplugin-nonfree/http_proxy:
  flashplugin-nonfree/failed:
  flashplugin-nonfree/local:
  flashplugin-nonfree/delete: false

-- 
Pelle


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to