Source: libguestfs
Version: 1:1.38.6-1
Severity: normal
Tags: patch
Control: block 906016 by -1
libguestfs build-depends on gjs, which is based on the Mozilla
Spidermonkey JavaScript interpreter (mozjs). mozjs has a history of being
poorly supported (read: not actually working) on unusual architectures,
in particular mips* and s390x.
The GNOME team is currently trying to migrate from gjs 1.52.x (mozjs52)
to 1.54.x (mozjs60). mozjs52 mostly worked on s390x, but mozjs60 fails
around 80% of its tests there, and fixing that seems unlikely, so we are
intending to do an architecture-specific removal of gjs:s390x and the
packages that depend on it.
Please make this build-dependency conditional on [!s390x], as has already
been done in Ubuntu for a while, so that libguestfs will remain buildable
on s390x (albeit with reduced test coverage). I attach a possible patch.
smcv
>From eb501d9eaf7f10be864f050da5c90eec6b38eea5 Mon Sep 17 00:00:00 2001
From: Simon McVittie <[email protected]>
Date: Thu, 4 Oct 2018 13:19:59 +0100
Subject: [PATCH] Don't build-depend on gjs on s390x or when not running tests
gjs is based on mozjs, the Mozilla Spidermonkey JavaScript interpreter,
which has a history of working poorly on s390x. In particular, the
latest version of mozjs, mozjs60, doesn't appear to work on s390x.
libguestfs only uses gjs to run extra tests, so removing this dependency
seems harmless.
While I'm changing this line anyway, also annotate it as <!nocheck>.
I've verified that the amd64 package can build successfully without it.
---
debian/control | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/debian/control b/debian/control
index f599e7fba..535e1feeb 100644
--- a/debian/control
+++ b/debian/control
@@ -39,7 +39,7 @@ Build-Depends: debhelper (>= 10),
libstring-shellquote-perl,
libsys-virt-perl, libwin-hivex-perl,
libfuse-dev, fuse,
- libglib2.0-dev, gjs, gobject-introspection, libgirepository1.0-dev,
+ libglib2.0-dev, gjs [!s390x] <!nocheck>, gobject-introspection, libgirepository1.0-dev,
libgtk2.0-dev,
db-util,
netpbm, icoutils,
--
2.19.0
