On Wednesday, 10 October 2018 5:00:55 PM AEDT Steve Langasek wrote: > While the consul source package has successfully built in Debian, in Ubuntu > we find that it is failing to build because certain go libraries that are > needed by the source but are not declared as build-dependencies happen to > not be pulled in as indirect build-dependencies. > > src/github.com/hashicorp/consul/vendor/github.com/hashicorp/go-discover/pr > ovider/aws/aws_discover.go:9:2: cannot find package > "github.com/aws/aws-sdk-go/aws" in any of: > /<<PKGBUILDDIR>>/_build/src/github.com/hashicorp/consul/vendor/github.com/ > aws/aws-sdk-go/aws (vendor tree) > /usr/lib/go-1.10/src/github.com/aws/aws-sdk-go/aws (from $GOROOT) > /<<PKGBUILDDIR>>/_build/src/github.com/aws/aws-sdk-go/aws (from $GOPATH) > src/github.com/hashicorp/consul/vendor/github.com/hashicorp/go-discover/pr > ovider > > (https://launchpad.net/ubuntu/+source/consul/1.0.7~dfsg1-5) > > There are a number of other missing packages after this first one. > > Since these go packages are used by the consul source, it is per se correct > for consul to declare build dependencies on them, even if the package has > successfully built in Debian without the declaration. > > Please consider the attached patch, which I have uploaded to Ubuntu to fix > the build failure there.
Thanks. Indeed few dependencies are missing: golang-github-docker-go-connections-dev golang-github-kr-text-dev However the following packages are not direct dependencies of Consul therefore they donot belong to Build-Depends. It is wrong to add those: golang-github-aws-aws-sdk-go-dev golang-google-api-dev Indirect dependencies should be declared in relevant packages outside of Consul. -- All the best, Dmitry Smirnov. --- The surest way to corrupt a youth is to instruct him to hold in higher esteem those who think alike than those who think differently. -- Friedrich Nietzsche
signature.asc
Description: This is a digitally signed message part.