On Wed, 11 Jul 2018 10:38:51 -0400 Sandro Tosi <mo...@debian.org> wrote: > control: tags -1 - patch > > On Wed, Jul 11, 2018 at 10:29 AM Bas Couwenberg <sebas...@xs4all.nl> wrote: > > > > On 2018-07-11 16:23, Sandro Tosi wrote: > > > On Wed, Jul 11, 2018 at 10:03 AM Bas Couwenberg <sebas...@xs4all.nl> > > > wrote: > > >> The _geoslib.c file needs to regenerated with a recent Cython to be > > >> compatible with Python 3.7. > > > > > > the attached patch looks it's including only the regenerated files, > > > wouldnt it be better to b-d on cython and actual regenerate the .c > > > file at debian package build time? > > > > That would be better, but not something I'm willing to spend my time on. > > fair enough, but as is this patch cannot be accepted.
Don't let the perfect be the enemy of good. The patch is fine: your package already ships a pre-built file, so updating it is a fine solution to fix this bug and let us move on with the python3 transition. Sure, regenerating it at build time would be better, but that can be done later if you don't have the time to do it now. For the time being, this patch is no different than when we had to manually run autoreconf and ship the results in a patch to get an updated config.guess, for example. I'd propose to ship this now and file a bug upstream asking to generate the file during the build. Then you can drop the patch when that happens (or when they just update the file to a new version, whichever happens first). Cheers, Emilio
