Hello, On Wed 10 Oct 2018 at 01:51AM +0100, Ian Jackson wrote:
> Also, arguably something should have stopped you proceeding with an > untracked unignored files (perhaps, especially as you specified -wc). > But the clean mode is basically ignored with build-source (and > push-source) since the tree does not need to be cleaned. But spotting > uncommitted files is important. I'm pretty sure this is a straightforward bug -- unless --ignore-dirty or --include-dirty is specified, push-source and build-source are meant to error out if the tree is dirty. > I'm not sure exactly what to do about this but I have cloned this bug > to track this issue. It seems odd to say that --clean=check ought to > make build-source and push-source check for loose files, even though > they usually don't actually clean the tree at all. Perhaps there > should be a separate check which doesn't depend on the clean mode ? I don't follow what's difficult about this. push-source and build-source should always just check for a dirty tree, and error out, unless they've been told not to. The presence of absence of -wc does not seem relevant. -- Sean Whitton
signature.asc
Description: PGP signature
