Package: devscripts
Version: 2.18.7
Severity: normal
Tags: patch
When running uscan, I get the following warning message:
$ mkdir test
$ cd test
$ uscan --report
Useless use of concatenation (.) or string in void context at
/usr/share/perl5/Devscripts/Uscan/Downloader.pm line 106.
Attached is a very simple patch that fixes this.
Francois
-- Package-specific info:
--- /etc/devscripts.conf ---
--- ~/.devscripts ---
DSCVERIFY_KEYRINGS=~/.gnupg/pubring.gpg
USCAN_SYMLINK=no
-- System Information:
Debian Release: buster/sid
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.18.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_CA.UTF-8, LC_CTYPE=fr_CA.UTF-8 (charmap=UTF-8),
LANGUAGE=fr_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages devscripts depends on:
ii dpkg-dev 1.19.2
ii fakeroot 1.23-1
ii file 1:5.34-2
ii gnupg 2.2.10-3
ii gpgv 2.2.10-3
ii libc6 2.27-8
ii libfile-homedir-perl 1.004-1
ii libfile-which-perl 1.22-1
ii libipc-run-perl 20180523.0-1
ii libmoo-perl 2.003004-2
ii libwww-perl 6.36-1
ii patchutils 0.3.4-2
ii perl 5.28.0-3
ii python3 3.6.7-1
ii sensible-utils 0.0.12
ii wdiff 1.2.2-2+b1
Versions of packages devscripts recommends:
ii apt 1.7.0
ii at 3.1.23-1
ii curl 7.62.0-1
ii dctrl-tools 2.24-3
ii debian-keyring 2018.09.30
ii dput-ng [dput] 1.21
ii dupload 2.9.2
ii equivs 2.1.1
ii libdistro-info-perl 0.20
ii libdpkg-perl 1.19.2
ii libencode-locale-perl 1.05-1
ii libgit-wrapper-perl 0.048-1
ii liblist-compare-perl 0.53-1
ii liblwp-protocol-https-perl 6.07-2
ii libsoap-lite-perl 1.27-1
ii libstring-shellquote-perl 1.04-1
ii libtry-tiny-perl 0.30-1
ii liburi-perl 1.74-1
ii licensecheck 3.0.31-3
ii lintian 2.5.111
ii man-db 2.8.4-2+b1
ii patch 2.7.6-3
ii python3-apt 1.7.0
ii python3-debian 0.1.33
ii python3-magic 2:0.4.15-2
ii python3-requests 2.20.0-2
ii python3-unidiff 0.5.4-1
ii python3-xdg 0.25-4
ii strace 4.21-1
ii unzip 6.0-21
ii wget 1.19.5-2
ii xz-utils 5.2.2-1.3
Versions of packages devscripts suggests:
pn adequate <none>
ii autopkgtest 5.6
pn bls-standalone <none>
ii bsd-mailx [mailx] 8.1.2-0.20180807cvs-1
ii build-essential 12.5
pn check-all-the-things <none>
pn cvs-buildpackage <none>
pn devscripts-el <none>
pn diffoscope <none>
pn disorderfs <none>
ii dose-extra 5.0.1-11+b1
ii duck 0.13
pn faketime <none>
pn gnuplot <none>
pn how-can-i-help <none>
ii libauthen-sasl-perl 2.1600-1
pn libdbd-pg-perl <none>
ii libfile-desktopentry-perl 0.22-1
pn libnet-smtps-perl <none>
pn libterm-size-perl <none>
ii libtimedate-perl 2.3000-2
pn libyaml-syck-perl <none>
ii mozilla-devscripts 0.53
ii mutt 1.10.1-2
ii openssh-client [ssh-client] 1:7.9p1-1
pn piuparts <none>
ii postgresql-client-10 [postgresql-client] 10.5-1
ii postgresql-client-11 [postgresql-client] 11.0-1+b1
ii quilt 0.65-2
ii ratt 0.0~git20180127.c44413c-2
pn reprotest <none>
pn svn-buildpackage <none>
ii w3m 0.5.3-36+b1
-- no debconf information
--- Downloader.pm 2018-11-05 12:57:41.591465757 -0800
+++ Downloader.pm.patched 2018-11-05 12:58:07.300086945 -0800
@@ -103,9 +103,9 @@
$request = HTTP::Request->new('GET', "$url");
$response = $self->user_agent->request($request, $fname);
if (!$response->is_success) {
- uscan_warn(defined $pkg_dir ? "In directory $pkg_dir, d" : "D")
+ uscan_warn(defined $pkg_dir ? "In directory $pkg_dir, d" : "D"
. "ownloading\n $url failed: "
- . $response->status_line;
+ . $response->status_line);
return 0;
}
} else { # elsif ($$optref{'mode'} eq 'git')
