Roger,

thanks for getting back to me after so long. 

> The attached patch adds proper checking to downloaded sources.  This
> applies to current CVS, or sbuild 0.42 and other recent versions.

Ok.


> The first hunk takes care of verifying already downloaded sources.  If
> this fails, it downloads them again.  This fixes the main issue.

Good.


> The second hunk verifies /all/ sources prior to a build.  This has the
> effect of requiring all .dsc files to verify and be signed.
> Currently, we do allow unsigned .dsc files.

Yes... 

> The second hunk changes the behaviour of sbuild, but does make it more
> secure.

> Comments?

Well, actually I'd say the second behaviour should be the correct new
default. It should be having a switch though to enable and disable it,
allowing admins requiring unsigned sources (e.g. from their local
archive) to retain their current behaviour. Probably the package should
either ask through po-debconf whether it's to be enabled system-wide or
just left disabled and left to the individual user to overwrite that
default.

-- 
Best regards,
 Kilian

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil

Reply via email to