You're no doubt right that there's scope for improvement, and I don't want to go too far in defending a patch that I didn't write myself. But I would note that, as I understand matters, the patched hplip would only use IPv6 if either an IPv6 address was explicitly passed, or if the hostname resolved to an IPv6 address (say in /etc/hosts - which is what I tested). If that results in problems, then the system is arguably misconfigured elsewhere. These are (presumably most of the time) local network printers we're dealing with, so the state of their IPv6 support is known and controllable.
One possibility might be to test matters via an upload to experimental after the next release and watch for reports of breakage. Cheers, Christopher Martin On Mon, Nov 12, 2018 at 6:40 AM Julian Andres Klode <j...@debian.org> wrote: > > On Sun, Nov 11, 2018 at 02:47:12PM -0500, Christopher Martin wrote: > > Package: hplip > > Version: 3.18.10+dfsg0-2 > > Severity: wishlist > > Tags: patch ipv6 > > > > Please see https://bugs.launchpad.net/hplip/+bug/1724089 for the > > original report, which includes a patch that adds IPv6 support to > > libhpmud. > > > > The patch ensures that libhpmud properly resolves IPv6 addresses and > > hostnames. I've tested it against the latest hplip (3.18.10) and it > > works well. > > Having had the experience with dealing with IPv6 support in apt, I am not > convinced it's a good idea. The assumption that > > "The system's C library automatically selects the appropriate addresses (for > example, it omits ipv6 addresses if there is no ipv6 connectivity)." > > is wrong. We've heard a lot of reports from people without _working_ > IPv6 for which apt did not work, which forced me to implement a variant > of happy eyeballs. > > The patch in question does not try multiple address families in parallel, > nor does it seem to have any time out at all, meaning it will get stuck > indefinitely trying to connect to a broken ipv6 host. > > -- > debian developer - deb.li/jak | jak-linux.org - free software dev > ubuntu core developer i speak de, en
