Hello, On Tue, Nov 13, 2018 at 08:34:25AM +0100, Christian Ehrhardt wrote:
Package: chrony Version: 3.4-1 Severity: normalHi, in upstream chrony 3.4 there was a change [1] to the default pidfile path. Since we do not configure at build
We do ;-) From d/rules: “--with-pidfile=/run/chronyd.pid”
nor in the .conf file a different path we have followed this changed default path.Therefore I think we need a change to our service file like [2] to have it be aware of the right PIDs. What do you think?
As you can see above, only modifying the service file is certainly not enough. But I think there is something potentially subtler behind this change; since debhelper compat 10, the default behaviour is to not stop the service until after the package upgrade has been completed (i.e. in postinst) so I’m fairly sure that if you don’t override “dh_systemd_start” with the “--no-restart-after-upgrade” option, you are going to have a stale pidfile (our good old /run/chronyd.pid) while upgrading from a prior chrony version.
Considering these factors, I preferred not to change the pidfile location in Debian, even though I agree that it would be cleaner to have it in the “/run/chrony/” directory.
[1]: https://git.tuxfamily.org/chrony/chrony.git/commit/?id=e50dc739d88feca6e0da034406034f3d3cf60ca4 [2]: https://git.launchpad.net/~paelzer/ubuntu/+source/chrony/commit/?id=a035dfd03423a097e7f1bf27d7d4f124f03fdcc1 -- Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd
Have a good day Christian, Vincent
signature.asc
Description: PGP signature
