Package: release.debian.org
Severity: normal
Tags: stretch
User: release.debian....@packages.debian.org
Usertags: pu

Hello,

I would like to upload to stretch the attached changes.

The 1:0.80-5+deb9u2 upload that got in Debian 9.6 was meant to fix
the installability of the espeakup package on systems with default
configuration.  The change was tested fine in sid then buster.  It
however seems it didn't get enough testing in stretch, and it actually
breaks there :/ because systemd there is stricter on the ExecStart
content, which resulted to Bug#913453, effectively breaking speech
synthesis for non-sighted users :/  Also, when $VOICE is empty, in the
stretch version of espeakup the missing parameter gets a command line
parsing error.

The 1:0.80-5+deb9u3 version I'm proposing has now been tested by the bug
reporter and others.

Samuel

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 
'proposed-updates'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 
'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), 
(1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0 (SMP w/8 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: systemd (via /run/systemd/system)
diff -Nru espeakup-0.80/debian/changelog espeakup-0.80/debian/changelog
--- espeakup-0.80/debian/changelog      2018-11-02 00:39:25.000000000 +0100
+++ espeakup-0.80/debian/changelog      2018-11-11 17:43:08.000000000 +0100
@@ -1,3 +1,10 @@
+espeakup (1:0.80-5+deb9u3) stretch; urgency=high
+
+  * debian/espeakup.service: Fix compatibility with older versions of systemd
+    (Closes: Bug#913453). Also fix starting with empty voice language.
+
+ -- Samuel Thibault <sthiba...@debian.org>  Sun, 11 Nov 2018 17:43:08 +0100
+
 espeakup (1:0.80-5+deb9u2) stretch; urgency=medium
 
   * debian/espeakup.service: Automatically load speakup_soft on daemon
diff -Nru espeakup-0.80/debian/espeakup.service 
espeakup-0.80/debian/espeakup.service
--- espeakup-0.80/debian/espeakup.service       2018-11-02 00:38:55.000000000 
+0100
+++ espeakup-0.80/debian/espeakup.service       2018-11-11 17:43:08.000000000 
+0100
@@ -9,7 +9,7 @@
 PIDFile=/run/espeakup.pid
 Environment="VOICE= ALSA_CARD="
 EnvironmentFile=-/etc/default/espeakup
-ExecStart=sh -c 'modprobe speakup_soft && /usr/bin/espeakup -V ${VOICE}'
+ExecStart=/bin/sh -c 'modprobe speakup_soft && /usr/bin/espeakup -V "${VOICE}"'
 ExecReload=/bin/kill -HUP $MAINPID
 Restart=always
 

Reply via email to