Hi Martin

Am 16.11.18 um 18:32 schrieb Martin Pitt:
> I also added some postinst cleanup with some reasonable defensiveness.
> (Double-checking it now)
> 
> @Michael, does that seem ok to you?

The patch seems to work fine as is.
That said, lintian is not happy about the direct parsing and mangling of
/etc/group.

> W: systemd: maintainer-script-should-not-parse-etc-passwd-or-group 
> postinst:160 'grep '^nobody:x:' /etc/group'
> N: 
> N:    The maintainer script appears to manually parse /etc/passwd or
> N:    /etc/group instead of using the getent(1) utility to display entries.
> N:    
> N:    This bypasses the Name Service Switch (NSS), avoiding querying
> N:    centralised or networked user databases such as LDAP, etc.
> N:    
> N:    Refer to the getent(1) manual page and the nss(5) manual page for
> N:    details.
> N:    
> N:    Severity: normal, Certainty: possible
> N:    
> N:    Check: scripts, Type: binary
> N: 
> N: Finished processing group systemd/239-12

Any reason you didn't use "getent group" and "delgroup" ?

Cheers,
Michael
-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to