On 2018-11-21 17:41:39, Matthias Klose wrote:
> Control: tags -1 -moreinfo
>
> On 21.11.18 15:53, Antoine Beaupré wrote:
>> Control: tags -1 +moreinfo
>>
>> On 2018-11-21 12:56:40, Matthias Klose wrote:
>>> Package: src:monkeysign
>>> Version: 2.2.4
>>> Severity: important
>>> Tags: sid buster
>>> X-Debbugs-CC: [email protected]
>>> User: [email protected]
>>> Usertags: breaks needs-update
>>>
>>> monkeysign tries to access an external key server during the tests, and
>>> then in
>>> a restricted test environment, it fails tests. Please either use a proxy or
>>> disable the tests with network access.
>>
>> The network tests are disabled in the debian package build.
>>
>> They are not, in the normal test suite however.
>>
>> Do you mean to say that network access occurs in the package build? If
>> so, please provide a detailed build log.
>
> please see
> http://autopkgtest.ubuntu.com/packages/m/monkeysign/disco/amd64
>
> .ssssssssss
> ======================================================================
> ERROR: test_find_key (test_ui.KeyserverTests)
> this should find the key on the keyservers
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/usr/lib/python2.7/dist-packages/monkeysign/tests/test_ui.py", line
> 543,
> in test_find_key
> self.ui.find_key()
> File "/usr/lib/python2.7/dist-packages/monkeysign/ui.py", line 523, in
> find_key
> self.abort(_('could not find key %s in your keyring or keyservers') %
> self.pattern)
> File "/usr/lib/python2.7/dist-packages/monkeysign/ui.py", line 480, in abort
> sys.exit(message)
> SystemExit: could not find key 7B75921E in your keyring or keyservers
>
> ----------------------------------------------------------------------
> Ran 68 tests in 63.858s
>
> FAILED (errors=1, skipped=27, expected failures=1)
>
> so this tries to access a keyserver, doesn't it?
hmm... autopkgtest... that's not the package build! i guess i didn't
disable network tests there?
that class is covered by "@skipUnlessNetwork()" so it shouldn't be
running if tests are disabled with the PYTEST_NONETWORK
environment. We'd need to tweak the tests to require network or add that
environment...
what do you think?
a.
--
The lazy man does not stand in the way of progress. When he sees
progress roaring down upon him he steps nimbly out of the way
- Christopher Morley, "On Laziness"
